Add snippets project to Tycho build #1390 #1391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit f4c377b. ♻️ This comment has been updated with latest results. |
Member
|
Is there a plan to finish this one? |
Contributor
Author
|
From SWT side, this is kind of finished, but it's currently blocked until a further Tycho feature is implemented. Since I do not see any strong demand for that feature, we may also close this PR and accept the current situation. It's only about issues with snippet modifications always being detected late/manually, as there is no automated verification for them. |
The snippets project org.eclipse.swt.snippets is currently not part of the Tycho build. This change adds it to the build using a Maven plugin to copy the OS-specific classpath file according to the current environment. Contributes to eclipse-platform#1390
Member
|
Closing this one as Tycho side hadn't progressed in a year. Please reopen if/when Tycho used to compile platform supports the needed feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snippets project org.eclipse.swt.snippets is currently not part of the Tycho build. This change adds it to the build using a Maven plugin to copy the OS-specific classpath file according to the current environment.
Contributes to #1390